Skip to content

feat(tooling): typescript config package - #8433

Open
yomonom wants to merge 27 commits into
mainfrom
4500-global-tsconfig
Open

feat(tooling): typescript config package#8433
yomonom wants to merge 27 commits into
mainfrom
4500-global-tsconfig

Conversation

@yomonom

@yomonom yomonom commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📄 Description

  • Add a new package that provides re-usable typescript configurations
  • Ensure type checks are run on every build in existing packages and apps

🚀 Demo

n.A.

🔮 Design review

  • Design review done
  • No design review needed

🧪 Visual regression tests

  • Visual changes detected and approved (Check this box if VRT fails and changes are intentional)

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

yomonom added 13 commits September 7, 2026 11:06
@yomonom
chore: add global typescript configurations
fd56a6b
@yomonom
chore: integrate global typescript config into components package
f42b7fb
@yomonom
chore: integrate global typescript config into tokens package
33e9d89
@yomonom
chore: remove leftover *.tsbuildinfo
02af3d9
@yomonom
chore: integrate global typescript config into github-changelog package
6c871ae
@yomonom
chore: integrate global typescript config into components-angular pac…
d5075fd 
…kage
@yomonom
chore: integrate global typescript config into components-react package
240fe53
@yomonom
chore: integrate global typescript config into icons package
5ebb8cb
@yomonom
chore: integrate global typescript config into header package
a33f8ec
@yomonom
chore: integrate global typescript config into eslint package
0f141e1
@yomonom
chore: integrate global typescript config into styles-primeng and the…
521e310 
…me-ag-grid packages
@yomonom
chore: add check script
d38cd2f
@yomonom
chore: integrate global typescript into integration apps
a186c18
@yomonom yomonom linked an issue Sep 7, 2026 that may be closed by this pull request
Create a global tsconfig #4500
Open
@changeset-bot

changeset-bot Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 21d459d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yomonom
yomonom force-pushed the 4500-global-tsconfig branch from 7936075 to a0af7e6 Compare September 7, 2026 10:29
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Icon Validation Report

✅ Validation Passed

All icons have been validated successfully!

📊 Statistics

Metric Value
Total Icons 2741
✅ Successful 2741
❌ Failed 0
Pass Rate 100.0%

🎉 Perfect!

No issues detected. All icons meet quality standards.

@swisspost-bot

swisspost-bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related Previews

@yomonom
yomonom force-pushed the 4500-global-tsconfig branch from a0af7e6 to 282cb14 Compare September 7, 2026 10:36
@yomonom
yomonom marked this pull request as ready for review September 7, 2026 11:35
@yomonom
yomonom requested review from a team as code owners September 7, 2026 11:35
@yomonom

yomonom commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Created a new /tooling directory, since at least two more packages will follow #4487.

This also aligns with PostOne.

@yomonom
yomonom force-pushed the 4500-global-tsconfig branch from f916fba to 46a629d Compare September 8, 2026 11:14
@yomonom
yomonom force-pushed the 4500-global-tsconfig branch 2 times, most recently from 52a7d89 to ddb6d62 Compare September 8, 2026 12:23
@alionazherdetska alionazherdetska linked an issue Sep 8, 2026 that may be closed by this pull request
Consolidate eslint, stylelint and prettier config #4487
Open
@yomonom yomonom removed a link to an issue Sep 8, 2026
Consolidate eslint, stylelint and prettier config #4487
Open
alionazherdetska
alionazherdetska requested changes Sep 8, 2026
View reviewed changes

@alionazherdetska alionazherdetska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite a neat PR, nice to see everything consolidated into a shared config like this.

One thing I noticed is that none of the workflows in .github/workflows actually call typecheck yet so it's something we can run locally but it doesn't gate anything in CI. That means a PR could still merge with type errors even though we now have all this infrastructure in place to catch them. Should we maybe add it as a step in lint.yaml alongside the existing lint step, once the documentation typecheck is sorted out?

Comment thread apps/documentation/package.json
Comment thread apps/documentation/tsconfig.json
@yomonom

yomonom commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

quite a neat PR, nice to see everything consolidated into a shared config like this.

One thing I noticed is that none of the workflows in .github/workflows actually call typecheck yet so it's something we can run locally but it doesn't gate anything in CI. That means a PR could still merge with type errors even though we now have all this infrastructure in place to catch them. Should we maybe add it as a step in lint.yaml alongside the existing lint step, once the documentation typecheck is sorted out?

I would very much like that, and I have already discussed it with Oli. However, the same is also true of formatting: currently, the CI does not guard against incorrectly formatted files. Therefore, I think it's best to address adjusting the CI in a separate issue.

However, I made sure that typecheck is run as part of every build script (except for the docs package), so it is actually run as part of the CI (just not that clean).

@yomonom yomonom changed the title chore: global typescript configuration feat(tooling): typescript config package Sep 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@yomonom
yomonom added this pull request to stack #8456 September 9, 2026 15:03
alionazherdetska
alionazherdetska approved these changes Sep 11, 2026
View reviewed changes

@alionazherdetska alionazherdetska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small one, but worth fixing before this gets published:

json
"repository": {
"type": "git",
"url": "https://github.com/swisspost/design-system.git",
"directory": "packages/tsconfig"
}

This still points at packages/tsconfig, but the package now lives at tooling/typescript/package.json, the leftover from the earlier moves

@yomonom

yomonom commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Small one, but worth fixing before this gets published:

json "repository": { "type": "git", "url": "https://github.com/swisspost/design-system.git", "directory": "packages/tsconfig" }

This still points at packages/tsconfig, but the package now lives at tooling/typescript/package.json, the leftover from the earlier moves

This will be addressed in #8443. See this diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alionazherdetska alionazherdetska alionazherdetska approved these changes
@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a global tsconfig

3 participants

@yomonom @swisspost-bot @alionazherdetska